-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-#6469: pin numexpr<2.8.5 #6474
Conversation
Signed-off-by: Anatoly Myachev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but let's fix the English 🙃
Co-authored-by: Vasily Litvinov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @anmyachev!
I think we should have the pin in setup.py too. If I installed modin from source, I would get an error like in the issue, right? |
This is an optional dependency and should not be installed with Modin by default. |
pydantic is also an optional dependency but we have a pin for it in setup.py. |
IIRC |
Anyway, if Modin doesn't work out of the box without the pin for numexpr, I think we should fix the things. Would you mind to open a PR so other maintaners take a look at the fix? |
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
It's more quickly just ping @modin-project/modin-core here |
What do these changes do?
Fix CI on master branch.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date