Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#6469: pin numexpr<2.8.5 #6474

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Aug 8, 2023

What do these changes do?

Fix CI on master branch.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves numexpr 2.8.5 breaks CI #6469
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev requested a review from a team as a code owner August 8, 2023 17:47
@anmyachev anmyachev added the P0 Highest priority tasks requiring immediate fix label Aug 8, 2023
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but let's fix the English 🙃

environment-dev.yml Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
requirements/env_hdk.yml Outdated Show resolved Hide resolved
requirements/env_unidist.yml Outdated Show resolved Hide resolved
requirements/requirements-no-engine.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anmyachev!

@vnlitvinov vnlitvinov merged commit 58f850d into modin-project:master Aug 9, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6469 branch August 9, 2023 11:30
@YarShev
Copy link
Collaborator

YarShev commented Aug 20, 2023

I think we should have the pin in setup.py too. If I installed modin from source, I would get an error like in the issue, right?

@anmyachev
Copy link
Collaborator Author

I think we should have the pin in setup.py too. If I installed modin from source, I would get an error like in the issue, right?

This is an optional dependency and should not be installed with Modin by default.

@YarShev
Copy link
Collaborator

YarShev commented Aug 21, 2023

pydantic is also an optional dependency but we have a pin for it in setup.py.

@anmyachev
Copy link
Collaborator Author

IIRC pydantic is installed with ray[default]. It is not optional for modin[ray].

@YarShev
Copy link
Collaborator

YarShev commented Aug 21, 2023

Anyway, if Modin doesn't work out of the box without the pin for numexpr, I think we should fix the things. Would you mind to open a PR so other maintaners take a look at the fix?

RehanSD pushed a commit that referenced this pull request Aug 22, 2023
RehanSD pushed a commit that referenced this pull request Aug 22, 2023
RehanSD pushed a commit that referenced this pull request Aug 22, 2023
@anmyachev
Copy link
Collaborator Author

Anyway, if Modin doesn't work out of the box without the pin for numexpr, I think we should fix the things. Would you mind to open a PR so other maintaners take a look at the fix?

It's more quickly just ping @modin-project/modin-core here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority tasks requiring immediate fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numexpr 2.8.5 breaks CI
3 participants