Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#6440: Use different HDK parameters for different queries #6441

Merged
merged 3 commits into from
Aug 4, 2023
Merged

FEAT-#6440: Use different HDK parameters for different queries #6441

merged 3 commits into from
Aug 4, 2023

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

Disable lazy_fetch and columnar_output for groupby and enable for join queries.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Use different HDK parameters for different queries #6440
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko
FEAT-modin-project#6440: Use different HDK parameters for different q…
0654adb 
…ueries

Disable lazy_fetch and columnar_output for groupby and enable for
join queries.

Signed-off-by: Andrey Pavlenko <[email protected]>
@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review August 1, 2023 23:02
@AndreyPavlenko AndreyPavlenko requested a review from a team as a code owner August 1, 2023 23:02
anmyachev
anmyachev previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreyPavlenko @anmyachev
Update modin/experimental/core/execution/native/implementations/hdk_o…
8a52474 
…n_native/partitioning/partition_manager.py

Co-authored-by: Anatoly Myachev <[email protected]>
anmyachev
anmyachev approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmyachev anmyachev merged commit 1d33014 into modin-project:master Aug 4, 2023
37 checks passed
anmyachev added a commit to anmyachev/modin that referenced this pull request Aug 4, 2023
@AndreyPavlenko @anmyachev
FEAT-modin-project#6440: Use different HDK parameters for different q…
3054f34 
…ueries (modin-project#6441)

* FEAT-modin-project#6440: Use different HDK parameters for different queries

Disable lazy_fetch and columnar_output for groupby and enable for
join queries.

Signed-off-by: Andrey Pavlenko <[email protected]>
Co-authored-by: Anatoly Myachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov left review comments

@anmyachev anmyachev anmyachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use different HDK parameters for different queries
3 participants
@AndreyPavlenko @vnlitvinov @anmyachev