Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#6439: create HDK environment manually for ASV #6431

Merged
merged 6 commits into from
Aug 3, 2023
Merged

TEST-#6439: create HDK environment manually for ASV #6431

merged 6 commits into from
Aug 3, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jul 31, 2023 •
edited
Loading

What do these changes do?

The changes works: https://github.com/modin-project/modin/actions/runs/5729826080/job/15527659650

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Create HDK environment manually for ASV #6439
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
don't use python 3.7 for ASV testing of HDK
c19e738 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
try python 3.8
0a9feb1 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
manual env creation
146e471 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
install asv again
749f226 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
install modin
693d39e 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
cleanup
f9e89ce 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev anmyachev changed the title TEST-#0000: don't use python 3.7 for ASV testing of HDK TEST-#0000: create HDK environment manually for ASV Aug 1, 2023
@anmyachev anmyachev changed the title TEST-#0000: create HDK environment manually for ASV TEST-#6439: create HDK environment manually for ASV Aug 1, 2023
@anmyachev anmyachev marked this pull request as ready for review August 1, 2023 19:19
@anmyachev anmyachev requested a review from a team as a code owner August 1, 2023 19:19
vnlitvinov
vnlitvinov approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vnlitvinov vnlitvinov merged commit 5240feb into modin-project:master Aug 3, 2023
33 checks passed
@anmyachev anmyachev deleted the change-python-asv branch August 3, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create HDK environment manually for ASV
2 participants
@anmyachev @vnlitvinov