Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6429: exclude pymssql==2.2.8 from environments #6430

Merged
merged 1 commit into from
Aug 1, 2023
Merged

FIX-#6429: exclude pymssql==2.2.8 from environments #6430

merged 1 commit into from
Aug 1, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jul 31, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves pymssql 2.2.8 brokes CI #6429
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev added the P0 Highest priority tasks requiring immediate fix label Jul 31, 2023
@anmyachev anmyachev marked this pull request as ready for review July 31, 2023 12:25
@anmyachev anmyachev requested a review from a team as a code owner July 31, 2023 12:25
@dchigarev dchigarev merged commit 0e0a2e6 into modin-project:master Aug 1, 2023
33 checks passed
@anmyachev anmyachev deleted the issue6429 branch August 1, 2023 12:08
RehanSD pushed a commit that referenced this pull request Aug 2, 2023
@anmyachev @RehanSD
FIX-#6429: exclude pymssql==2.2.8 from environments (#6430)
16b275b 
Signed-off-by: Anatoly Myachev <[email protected]>
RehanSD pushed a commit that referenced this pull request Aug 16, 2023
@anmyachev @RehanSD
FIX-#6429: exclude pymssql==2.2.8 from environments (#6430)
236c0e7 
Signed-off-by: Anatoly Myachev <[email protected]>
RehanSD pushed a commit that referenced this pull request Aug 22, 2023
@anmyachev @RehanSD
FIX-#6429: exclude pymssql==2.2.8 from environments (#6430)
665566f 
Signed-off-by: Anatoly Myachev <[email protected]>
RehanSD pushed a commit that referenced this pull request Aug 22, 2023
@anmyachev @RehanSD
FIX-#6429: exclude pymssql==2.2.8 from environments (#6430)
954ae71 
Signed-off-by: Anatoly Myachev <[email protected]>
RehanSD pushed a commit that referenced this pull request Aug 22, 2023
@anmyachev @RehanSD
FIX-#6429: exclude pymssql==2.2.8 from environments (#6430)
a014414 
Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
P0 Highest priority tasks requiring immediate fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pymssql 2.2.8 brokes CI
3 participants
@anmyachev @YarShev @dchigarev