FIX-#5091: Handle pd.Grouper objects correctly #6174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2023 10:23
Signed-off-by: Karthik Velayutham <[email protected]>
mvashishtha
reviewed
May 19, 2023
| @@ -573,11 +573,19 @@ def _internal_by(self): | |||
| internal_by = tuple() | |||
| if self._drop: | |||
| if is_list_like(self._by): | |||
| internal_by = tuple(by for by in self._by if isinstance(by, str)) | |||
7 tasks
mvashishtha
approved these changes
May 19, 2023
mvashishtha
requested changes
May 19, 2023
| @@ -573,11 +573,19 @@ def _internal_by(self): | |||
| internal_by = tuple() | |||
| if self._drop: | |||
| if is_list_like(self._by): | |||
| internal_by = tuple(by for by in self._by if isinstance(by, str)) | |||
There was a problem hiding this comment.
resolved. there's a separate test case for order now, but this doesn't fix #6164
| ) | ||
| def test_groupby_with_grouper(by): | ||
| # See https://github.com/modin-project/modin/issues/5091 for more details | ||
| data = { |
There was a problem hiding this comment.
@pyrito can you add some more columns too? We should have multiple column partitions on ray/dask
mvashishtha
previously approved these changes
May 19, 2023
|
@pyrito you now have a merge conflict 😢 |
devin-petersohn
approved these changes
May 22, 2023
devin-petersohn
approved these changes
May 22, 2023
pyrito
pushed a commit
to ponder-org/modin-public
that referenced
this pull request
May 22, 2023
…oject#6174) Signed-off-by: Karthik Velayutham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR addresses two issues - it handles pd.Grouper objects correctly and also obeys the order of the groupby sorting keys as passed in.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date