-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Add mypy checks for modin.core.dataframe.algebra #5167
base: master
Are you sure you want to change the base?
Conversation
@pyrito @mvashishtha guys I aint able to understand why is this error occurring
|
This pull request introduces 1 alert when merging 797a888 into 6f0ff79 - view on LGTM.com new alerts:
|
@pyrito can you please help me out |
@mvashishtha can you please review the code now I don't think so there should be any issues, if there are some changes required do tell me |
@sofezticated-gentleman I still see quite a lot of formatting changes, e.g. in modin/_compat/pandas_api/py36/base.py. Could you please revert all those and push to your branch again? |
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date