Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove code.json, update scripts, fix release workflow #190

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jun 17, 2024

Fixes for the release automation after discussion with @jdhughes-usgs

  • don't version code.json, just generate when needed (and update update_version.py)
  • add retries for metadata file gen in release.yml (USGS endpoints are unreliable)
  • fix autocommit/pr contents: version.txt, pymake/config.py, and README.md

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.051%. Comparing base (006b6ba) to head (ced4a26).

Additional details and impacted files
@@              Coverage Diff              @@
##           develop      #190       +/-   ##
=============================================
- Coverage   77.946%   70.051%   -7.895%     
=============================================
  Files           20        20               
  Lines         3496      3496               
=============================================
- Hits          2725      2449      -276     
- Misses         771      1047      +276     

see 11 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review June 17, 2024 21:15
@wpbonelli wpbonelli merged commit 9aaef25 into modflowpy:develop Jun 17, 2024
14 checks passed
@wpbonelli wpbonelli deleted the multiple branch June 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant