Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use setup-fortran, use major version tags for actions #139

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 13, 2023

  • use fortran-lang/setup-fortran instead of modflowpy/install-gfortran-action (latter to be retired soon)
  • use major version instead of full version tags for actions (less upkeep, fewer dependabot PRs)
  • consolidate gcc test jobs in single matrix
  • test gcc 11-13
  • test python 3.11

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #139 (3a1a31c) into master (a67f11b) will decrease coverage by 0.291%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master      #139       +/-   ##
=============================================
- Coverage   81.630%   81.340%   -0.291%     
=============================================
  Files           20        20               
  Lines         3446      3446               
=============================================
- Hits          2813      2803       -10     
- Misses         633       643       +10     

see 2 files with indirect coverage changes

@wpbonelli
Copy link
Member Author

wpbonelli commented Oct 13, 2023

@jdhughes-usgs I considered consolidating gcc in a single matrix with 11-13 since 10 and below are out of maintenance but didn't know if there were good reasons to keep the max at 11 (e.g., maybe some programs can't be built with newer gcc). Do you have any objections?

* use fortran-lang/setup-fortran action
* use major version tags for actions
* consolidate gcc/python tests in 1 matrix
* bump gcc versions tested to 11-13
* bump python versions tested to 3.8-3.11
@wpbonelli
Copy link
Member Author

wpbonelli commented Oct 15, 2023

Updated to gcc 11-13 and python 3.8-3.11, all seems to build ok. There is a pytest issue to resolve with python 3.12, I will take a second look at it sometime but for now this should be ok to go

@jdhughes-usgs jdhughes-usgs merged commit 5cd0858 into modflowpy:master Oct 16, 2023
17 checks passed
@wpbonelli wpbonelli deleted the ci branch October 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants