Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the role to "user" in format function of ollama chat model #443

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

zhijianma
Copy link
Collaborator

@zhijianma zhijianma commented Sep 14, 2024


name: Pull Request
about: Create a pull request

Description

[Please describe the background, purpose, changes made, and how to test this PR]
According to issue #441
Change role from system to user

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit fbd0e11 into modelscope:main Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:Incorrect role in Ollama_model ChatWrapper causing missing assistant messages
2 participants