-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stable-diffusion model wrapper #438
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the inline comments. Thank you!
Additionally, is it possible to launch the SD API server using a single, (interactive) bash script?
examples/conversation_with_stablediffusion_model/conversation_with_stablediffusion_model.py
Outdated
Show resolved
Hide resolved
examples/conversation_with_stablediffusion_model/conversation_with_stablediffusion_model.py
Outdated
Show resolved
Hide resolved
src/agentscope/models/__init__.py
Outdated
@@ -64,6 +67,7 @@ | |||
"ZhipuAIEmbeddingWrapper", | |||
"LiteLLMChatWrapper", | |||
"YiChatWrapper", | |||
"StableDiffusionTxt2imgWrapper", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change name to StableDiffusionImageSynthesisWrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change name to
StableDiffusionImageSynthesisWrapper
Since the SD API also provides an img2img interface, I think that both txt2img and img2img represent image synthesis, I'm concerned that naming the wrapper StableDiffusionImageSynthesisWrapper to represent text-to-image functionality might lead to confusion in the future if we decide to add an image-to-image wrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavdGao Please hv a look into this, thx.
And please pass the UT, thx! |
…pi) for SD-model invocation feat: add stablediffusion model services
I've made some updates to the PR:
|
Could you please further provide a minimal hardware requirement for running this demo on README? And the other part looks good to me. @DavdGao Please have a look at this PR. |
name: Pull Request
about: Create a pull request
Description
add stable-diffusion model wrapper
Integrate https://github.com/AUTOMATIC1111/stable-diffusion-webui
Checklist
Please check the following items before code is ready to be reviewed.