add fix

modelscope · Sep 10, 2024 · 2ae6cdb · 2ae6cdb
1 parent 8c1a668
commit 2ae6cdb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/agentscope/memory/temporary_memory.py b/src/agentscope/memory/temporary_memory.py
@@ -73,13 +73,12 @@ def add(
         else:
             record_memories = memories
 
+        # FIXME: a single message may be inserted multiple times
         # Assert the message types
         memories_idx = set(_.id for _ in self._content if hasattr(_, "id"))
         for memory_unit in record_memories:
             # in case this is a PlaceholderMessage, try to update
             # the values first
-            # TODO: Unify PlaceholderMessage and Msg into one class to avoid
-            #  type error
             if isinstance(memory_unit, AsyncResult):
                 memory_unit = memory_unit.result()
 

diff --git a/src/agentscope/server/async_result_pool.py b/src/agentscope/server/async_result_pool.py
@@ -118,8 +118,10 @@ def prepare(self) -> int:
         return self._get_object_id()
 
     def set(self, key: int, value: bytes) -> None:
+        qkey = RedisPool.TASK_QUEUE_PREFIX + str(key)
         self.pool.set(key, value, ex=self.max_timeout)
-        self.pool.rpush(RedisPool.TASK_QUEUE_PREFIX + str(key), key)
+        self.pool.rpush(qkey, key)
+        self.pool.expire(qkey, self.max_timeout)
 
     def get(self, key: int) -> bytes:
         result = self.pool.get(key)