Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add options input to runExperiment #27

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

maraberg
Copy link
Collaborator

@maraberg maraberg commented Jan 4, 2024

What?

Exposes 'options' in Experiment.run and Workspace.executeExperiment following the schema in /workspaces/{workspace}/experiments/{experimentId}/execution.

Why?

We don't want to always force a re-compilation of the model by default. With this solution the consumer can override the default (which is 'false')

Testing?

  • I have performed manual testing with the excel add-in and it works.
  • No unit or integration tests added.

Anything Else?

  • exposes the ExecutionOptions type as it might be needed for a consumer.

- add options to all implementations
- expose ExecutionOptions type
@maraberg maraberg changed the title Add options input to runExperiment fix: add options input to runExperiment Jan 4, 2024
@maraberg maraberg marked this pull request as ready for review January 4, 2024 13:53
@maraberg maraberg requested a review from x-oflisback January 4, 2024 14:01
@maraberg maraberg merged commit 29be1f2 into main Jan 4, 2024
1 of 2 checks passed
@maraberg maraberg deleted the topic/expose-experiment-execution-options branch January 4, 2024 14:07
@x-oflisback
Copy link
Contributor

🎉 This PR is included in version 3.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants