-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for initializing and terminating ME FMUs #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acb7c16
to
732ba1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thus far. Aside from the comments a few things we should also add here:
- explicit free_instance function + accompanied appropriate test.
- fmi3_import_destroy_dllfmu & fmi3_import_free_instance call in
__dealloc__
. See FMI2 for the various occurrences of_allocated_dll
and_allocated_fmu
. - [Optional] Related to
terminate
, some tests for valid/invalid call sequences, e.g., double termiante is not valid, and the FMU will only "midly" complain, not sure if this should be an error on the PyFMI side though
@PeterMeisrimelModelon see d9ae5a4 and 6e58cb5 |
PeterMeisrimelModelon
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terminate
function, reviewer can still review the rest.