Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build without distutils #98

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

jschueller
Copy link
Contributor

No description provided.

@PeterMeisrimelModelon
Copy link
Collaborator

Is this ready to be reviewed? I held off since it was still marked as "Draft". (I suppose same for modelon-community/PyFMI#236)

@jschueller jschueller marked this pull request as ready for review June 4, 2024 20:13
@jschueller
Copy link
Contributor Author

yes, this is ready: the skbuild/cmake path is not good enough because it does not allow to fully cross-compile the windows fortran modules with the 2 different compiler/linkers needed (msvc+msys/gfortran) like its currently done in conda-forge
instead I propose to use setuptools instead of distutils and ignore the fortran solvers for now with python>=3.12
it turns out we dont require them for what we do with pyfmi, but I suggest they get migrated to C in the long term (most are f77 and can be converted using f2c)

Copy link
Member

@modelonrobinandersson modelonrobinandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here too, just a minor comment, and add a changelog entry, thanks again!

@jschueller
Copy link
Contributor Author

done

@jschueller
Copy link
Contributor Author

hello @PeterMeisrimelModelon @modelonrobinandersson could we tag a new version with this ?

@modelonrobinandersson
Copy link
Member

hello @PeterMeisrimelModelon @modelonrobinandersson could we tag a new version with this ?

hi @jschueller I will get back tomorrow, I am just going to make a minor test on my end with these changes and then I hope to merge it.

@modelonrobinandersson modelonrobinandersson merged commit 6ea28a4 into modelon-community:master Jun 25, 2024
2 checks passed
@jschueller jschueller deleted the distutils branch June 25, 2024 18:03
modelonrobinandersson pushed a commit that referenced this pull request Jun 25, 2024
* Allow to build without distutils

* Drop svn version log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants