Fix build with sundials 7 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschueller
force-pushed
the
core2
branch
8 times, most recently
from
c6beb0d to
a76687d
Compare
jschueller
force-pushed
the
core2
branch
3 times, most recently
from
086fd58 to
30ffcf5
Compare
|
Could you review this one @modelonrobinandersson / @PeterMeisrimelModelon ? |
Closed
|
would it be possible to have a new release after that ? it would ease packaging for conda etc |
modelonrobinandersson
approved these changes
May 15, 2024
There was a problem hiding this comment.
@jschueller I think we are just missing a changelog entry, other than that it looks good to me.
|
@modelonrobinandersson done, and added one last commit to fix latex formulas escape (avoids SyntaxWarning) |
looks good to me! |
|
good for you too @PeterMeisrimelModelon ? |
PeterMeisrimelModelon
merged commit 214dbd6
into
modelon-community:master
2 checks passed
Closed
PeterMeisrimelModelon
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.