Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python3.11 and Cython3 #89

Merged
merged 7 commits into from
May 13, 2024

Conversation

PeterMeisrimelModelon
Copy link
Collaborator

No description provided.

@PeterMeisrimelModelon PeterMeisrimelModelon self-assigned this Apr 16, 2024
@PeterMeisrimelModelon
Copy link
Collaborator Author

PeterMeisrimelModelon commented Apr 19, 2024

@jschueller
I've made sure this is compatible with Sundials 6.7 & 7, but seeing a lot of messages in the form of

[ERROR][rank 0][path/to/some/sundials/source/file.c:line][SUNGlobalFallbackErrHandler] The SUNDIALS SUNContext was corrupt or NULL when an error occurred. As such, error messages have been printed to stderr.

when running the tests with Sundials 7. This seems to only affect CVode tests that test invalid calls/errors (Likely also affects IDA/Kinsol, but CVode has better test coverage).

Have you seen this before?
(This is not critical; the tests still pass, just not super pretty)

@jschueller
Copy link
Contributor

jschueller commented Apr 19, 2024

thats something I should have missed in the 6.x update because the SUNContext stuff was the new api of 6.x
anyway it should not block this long awaited new version

@PeterMeisrimelModelon PeterMeisrimelModelon merged commit 76bb9ca into master May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants