-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore init for clocked discretized. #3577
base: master
Are you sure you want to change the base?
Conversation
@@ -1400,13 +1400,13 @@ \subsection{Inferencing of solverMethod}\label{inferencing-of-solvermethod} | |||
|
|||
\section{Initialization of Clocked Partitions}\label{initialization-of-clocked-partitions} | |||
|
|||
The standard scheme for initialization of Modelica models does not apply for clocked base-partitions. | |||
The standard scheme for initialization of Modelica models does not apply for discrete-time sub-partitions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we drop the sub here? I can't find a single example of discrete-time sub-partition in the current text?
The standard scheme for initialization of Modelica models does not apply for discrete-time sub-partitions. | |
The standard scheme for initialization of Modelica models does not apply for discrete-time partitions. |
\item | ||
Attribute \lstinline!fixed! cannot be applied to variables in clocked partitions. | ||
Attribute \lstinline!fixed! cannot be applied to variables in discrete-time sub-partitions. | ||
The attribute \lstinline!fixed! is true for variables to which \lstinline!previous! is applied, otherwise false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, shouldn't we avoid the problem when previous
is applied to a parameter or constant?
The attribute \lstinline!fixed! is true for variables to which \lstinline!previous! is applied, otherwise false. | |
The attribute \lstinline!fixed! is true for clocked states, otherwise false. |
\item | ||
Attribute \lstinline!fixed! cannot be applied to variables in clocked partitions. | ||
Attribute \lstinline!fixed! cannot be applied to variables in discrete-time sub-partitions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really allow fixed
to be applied to clocked states in clocked discretized continuous-time partitions? Wouldn't that conflict with fixed
already being defined for these variables?
Based on comment in modelica/ModelicaStandardLibrary#4465