Modify SSE config for server #23
Open
+37
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename to Kotlin style guide - remove NPE - manage paths clearly
e5l
requested changes
Dec 18, 2024
| /** | ||
| * Configures the Ktor Application to handle Model Context Protocol (MCP) over Server-Sent Events (SSE). | ||
| */ | ||
| public fun Application.MCP(block: () -> Server) { | ||
| public fun Routing.mcp(block: () -> Server) { |
There was a problem hiding this comment.
Please keep old extension for compatibility
| val servers = ConcurrentMap<String, Server>() | ||
|
|
||
| install(SSE) |
There was a problem hiding this comment.
Please keep SSE to have configuration simple
| @@ -10,45 +10,57 @@ import io.ktor.util.collections.* | |||
|
|
|||
| private val logger = KotlinLogging.logger {} | |||
|
|
|||
| public val Mcp: ApplicationPlugin<Unit> = createApplicationPlugin("Mcp") { | |||
| application.install(SSE) | |||
There was a problem hiding this comment.
Could you tell me what is the purpose of the plugin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify SSE config for server: