-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples in README #149
base: main
Are you sure you want to change the base?
Conversation
I've converted this to a draft as there are still some problems with the second example. Specifically, I'm getting errors that look like this in the terminal window where I launched the inspector:
Also, these same examples appear in the src/ModelContextProtocol/README.md file. We should decide if we need the same examples both places or if we could only put them in one file and reference them from the other. If we decide to keep them in both files then the other file will need to be fixed as well. |
@mikekistler, I think your local repo needs to be sync'd. The readme you're editing has already progressed further in main, and the one in the src/mpc folder was already deleted. (Also, fwiw, all the further issues I found in the readme are fixed in #126, but as that hasn't been merged yet, feel free to make changes separately.) |
Thanks @stephentoub ... I will wait for you to merge #126 and then fixup this PR to anything still missing. |
@mikekistler, my changes merged. Can you update your PR with whatever additional changes you'd like on top of that? |
@mikekistler, are you still planning to evolve this, or should we close it for now? |
Motivation and Context
The current samples in the README do not work and do not even build successfully.
How Has This Been Tested?
The new code is copied from a project that has been tested with the MCP Inspector tool.
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context