-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix challenges numbering #79
Conversation
Signed-off-by: Felipe R. Monteiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the blank page with -- to be a bit odd -- should we just wait until we have another challenge to be challenge 7? The challenges still go 6 -> 8 visually.
I like the changes to make the links to issues consistent. I was planning to write another challenge sometime next week, so I would propose that we avoid making this blank file and instead just wait for that to be challenge 7.
@carolynzech when I texted locally, this would lead to the wrong numbering of the challenges until we add the challenge 7 (the sequence didn't obey the numbering order when rendered). Am I missing something? If so, I can remove the blank page. If not, I'm ok with keeping it until we include a new challenge next week. |
Fwiw, i'm okay with the blank page until next week as well. @carolynzech's concern is valid, but this should be fixed shortly when we add our challenge. Feel free to disagree if you have strong opinions about this. @feliperodri Would it help to add a screenshot of what the index page looks like somewhere in the PR description? |
Signed-off-by: Felipe R. Monteiro <[email protected]>
@feliperodri you could also enable your fork to publish documentation from your
Which blank page are we talking about? |
@celinval I'll enable it. Meanwhile, here it's an imagine:
I already removed it. I added an unnecessary blank page. |
@celinval I think I need one more approval to get it merge. |
Hm, two approvals should be enough--seems like the check approval action is hanging. I'm going to try revoking my approval and then re-approving to see if that triggers the check. |
Dismissing review to re-approve, see comment
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.