-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run format check in our CI and fix repo format #205
Conversation
Ensure that everything is properly formatted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! What does the error look like when the formatting check fails?
It will contain the diff of the files in the temporary folder, like any rustfmt failure. |
Co-authored-by: Zyad Hassan <[email protected]>
I'll solve the merge conflicts after the second review |
When it fails, would it be possible for the script to print the command the user should run to format the code? |
I’ll re-approve once conflicts are resolved. |
Sure... I can do that |
Co-authored-by: Zyad Hassan <[email protected]>
idk why the github action is failing
Putting this PR in draft for now. I don't know what's causing the workflow failures. The failure in 03855ef
before it gets there. (By crashes, I mean my computer reboots--this is a MacOS kernel failure, not a nicely handled script error.) I need to investigate more. For now, I did update the repo with the result of running |
- Replace `--suffix` by `-t`. - Remove upstream folder from the test execution
35eaf92
to
6eafab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! These are nits, take or leave them.
Co-authored-by: Carolyn Zech <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Changed the
check-rustc.sh
script to run the format check. Also added a--bless
mode to apply the changes locally.This change also includes the result of running the script with the
--bless
mode on.Related to #38
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.