-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts & Harnesses for NonNull::read
, NonNull::read_volatile
, NonNull::read_unaligned
#156
Contracts & Harnesses for NonNull::read
, NonNull::read_volatile
, NonNull::read_unaligned
#156
Conversation
Addressed previous PR comments and Increased SIZE:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
@zhassan-aws Thank you! Waiting for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please resolve the conflict?
I've then asked to help review this. |
LGTM |
@zhassan-aws resolved conflicts and addressed all comments, ready to merge:
|
trigger approval workflow |
1 similar comment
trigger approval workflow |
Towards #53
Contracts & Harnesses for
NonNull::read
,NonNull::read_volatile
,NonNull::read_unaligned
Discussion
For the ensures clause in the contract for
NonNull::read
, I could not directly compare the value pointed by self and result due to unsized and lack of PartialEq implementation, and the comparison is currently moved to the harness.Verification
Successful verification:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.