Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts & Harnesses for NonNull::read, NonNull::read_volatile, NonNull::read_unaligned #156

Merged

Conversation

QinyuanWu
Copy link

@QinyuanWu QinyuanWu commented Nov 8, 2024

Towards #53

Contracts & Harnesses for NonNull::read, NonNull::read_volatile, NonNull::read_unaligned

Discussion

For the ensures clause in the contract for NonNull::read, I could not directly compare the value pointed by self and result due to unsized and lack of PartialEq implementation, and the comparison is currently moved to the harness.

Verification

Successful verification:

SUMMARY:
 ** 0 of 141 failed

VERIFICATION:- SUCCESSFUL
Verification Time: 0.1760525s

Complete - 5 successfully verified harnesses, 0 failures, 5 total.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@QinyuanWu QinyuanWu marked this pull request as ready for review November 8, 2024 00:42
@QinyuanWu QinyuanWu requested a review from a team as a code owner November 8, 2024 00:42
@QinyuanWu
Copy link
Author

QinyuanWu commented Nov 12, 2024

Addressed previous PR comments and Increased SIZE:

Checking harness ptr::non_null::verify::non_null_check_read_unaligned...
SUMMARY:
 ** 0 of 261 failed (4 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 18.91408s

Checking harness ptr::non_null::verify::non_null_check_read_volatile...
SUMMARY:
 ** 0 of 237 failed (4 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 15.834378s

Checking harness ptr::non_null::verify::non_null_check_read...
SUMMARY:
 ** 0 of 229 failed (4 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 38.454617s

Complete - 3 successfully verified harnesses, 0 failures, 3 total.

@zhassan-aws zhassan-aws self-assigned this Nov 13, 2024
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@QinyuanWu
Copy link
Author

@zhassan-aws Thank you! Waiting for another review.

Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please resolve the conflict?

@Eh2406
Copy link

Eh2406 commented Nov 14, 2024

I've then asked to help review this.

@HuStmpHrrr
Copy link

LGTM

@QinyuanWu
Copy link
Author

@zhassan-aws resolved conflicts and addressed all comments, ready to merge:

VERIFICATION:- SUCCESSFUL
Verification Time: 0.173812s

Complete - 9 successfully verified harnesses, 0 failures, 9 total.

@zhassan-aws zhassan-aws enabled auto-merge (squash) November 15, 2024 06:06
@zhassan-aws
Copy link

trigger approval workflow

1 similar comment
@zhassan-aws
Copy link

trigger approval workflow

@zhassan-aws zhassan-aws merged commit 94a31f5 into model-checking:main Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants