-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts & Harnesses for Reference Conversion APIs at std::NonNull #116
Contracts & Harnesses for Reference Conversion APIs at std::NonNull #116
Conversation
b06151b
to
dd5c870
Compare
Hi @carolynzech , thanks for your review and suggestions! I have updated the code based on your comments, and solved most of them. But one thing I can not directly do is add a in-bound check in function contracts for The reason is the input |
0c711fe
to
bd44fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Hi @carolynzech @qinheping , do you mind triggering the merge flow for this PR again, I just solved some conflicts, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trigger approval workflow
Description:
This PR introduces function contracts and proof harness for the NonNull pointer in the Rust core library. Specifically, it verifies reference conversion APIs, covering:
Proof harness:
Towards #53
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.