Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported methods from the codebase #280

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Sep 11, 2024

These methods are undocummented, without an implementation, and were never used

These methods are undocummented, without an implementation, and were never used
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The add remove and query I think are from the POC implementation for jgroups discovery. But that has been abandoned and code purged. So I think this is a remnant of that. But I defer to @jfclere

@jfclere
Copy link
Member

jfclere commented Sep 15, 2024

@rhusar yes those were for some testing of some jgroups stuff. They should be removed now.

@rhusar rhusar merged commit 4779589 into modcluster:main Sep 15, 2024
9 checks passed
@rhusar
Copy link
Member

rhusar commented Sep 15, 2024

Great, thanks @jfclere and @jajik !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants