Improve logging messages and levels #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
previously requested changes
Oct 10, 2023
jajik
force-pushed
the
logging
branch
2 times, most recently
from
d63b204
to
53aa83c
Compare
jajik
force-pushed
the
logging
branch
3 times, most recently
from
f711462
to
8ae0035
Compare
jfclere
reviewed
Oct 23, 2023
|
I changed some of the log levels according to the feedback. Once we resolve all of them, I'll squash the temporary commits. |
|
@jfclere Everything should be addressed. I rebased and squashed commits with changes based on the feedback. Thank you for that! |
jfclere
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #148
(Also add a few files into gitignore)