Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCLUSTER-794 mod_proxy_cluster gets stuck with 20 nodes #123

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Aug 2, 2023

Fix and new test for https://issues.redhat.com/browse/MODCLUSTER-794.

Add test for https://issues.redhat.com/browse/MODCLUSTER-794.

This branch is based on #120 so I'm opening this as a draft until it is merged.

@jajik jajik changed the title Modcluster 794 Modcluster 794 test Aug 2, 2023
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@jajik
Copy link
Collaborator Author

jajik commented Aug 10, 2023

Rebase done. Because the issue has not been fixed yet, I disabled this test as well (in CI).

@rhusar
Copy link
Member

rhusar commented Aug 10, 2023

So this is a test case for MODCLUSTER-794 – I personally prefer to get test cases merged as disabled and the person fixing the issue fixes and enables the test – @jfclere can weigh in.

@jajik
Copy link
Collaborator Author

jajik commented Aug 10, 2023

So this is a test case for MODCLUSTER-794

Yes.

@jajik jajik marked this pull request as ready for review August 15, 2023 10:40
@rhusar rhusar marked this pull request as draft August 28, 2023 11:45
@rhusar
Copy link
Member

rhusar commented Aug 28, 2023

Converted to draft PR since there are 'wip' commits.

@jajik jajik force-pushed the MODCLUSTER-794 branch 2 times, most recently from 75cb207 to 2e82a7b Compare August 30, 2023 10:29
@jajik jajik changed the title Modcluster 794 test Modcluster 794 Aug 30, 2023
@jajik jajik marked this pull request as ready for review August 30, 2023 11:33
@jajik
Copy link
Collaborator Author

jajik commented Aug 30, 2023

Marking ready for review. It's no longer the test only, but there is a fix too.

@jajik jajik requested review from rhusar and jfclere August 30, 2023 11:34
@rhusar rhusar changed the title Modcluster 794 MODCLUSTER-794 mod_proxy_cluster gets stuck with 20 nodes Aug 30, 2023
@rhusar
Copy link
Member

rhusar commented Aug 30, 2023

Marking ready for review. It's no longer the test only, but there is a fix too.

Great. @jfclere please review.

native/mod_proxy_cluster/mod_proxy_cluster.c Outdated Show resolved Hide resolved
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@rhusar rhusar merged commit 93ffabe into modcluster:main Sep 4, 2023
7 checks passed
@rhusar
Copy link
Member

rhusar commented Sep 4, 2023

Thanks @jajik and @jfclere

@jajik jajik deleted the MODCLUSTER-794 branch September 18, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants