Emit correct type stubs for async functions wrapped with additional decorators #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
force-pushed
the
michael/2024-12-10-support-wrapped-functions
branch
from
f9b01a7 to
076ba13
Compare
freider
reviewed
Dec 11, 2024
freider
reviewed
Dec 11, 2024
freider
reviewed
Dec 16, 2024
src/synchronicity/async_wrap.py
Outdated
| @@ -38,6 +38,15 @@ async def wrapper(*args, **kwargs): | |||
| return functools.wraps(func) | |||
|
|
|||
|
|
|||
| def is_coroutine_function_follow_wrapped(func: typing.Callable) -> bool: | |||
| """Determine if a function returns a coroutine, unwrapping decorators, but not the async synchronicitiy interace.""" | |||
There was a problem hiding this comment.
nit: Typo in docstring: synchronicitiy
freider
reviewed
Dec 16, 2024
freider
reviewed
Dec 16, 2024
mwaskom
force-pushed
the
michael/2024-12-10-support-wrapped-functions
branch
from
b06bfa8 to
a1f7e00
Compare
mwaskom
force-pushed
the
michael/2024-12-10-support-wrapped-functions
branch
from
57df19c to
8b4b763
Compare
|
@prbot approve |
|
Please request a reviewer to follow up with a post-merge review. |
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
freider
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically stumbled around in the dark until I got this working, so I'm not sure it's correct or ideal. But it gets my test case and actual usecase working AFAICT.