Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds typing_extensions as explicit dependency #124

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

freider
Copy link
Contributor

@freider freider commented Jan 26, 2024

It's used outside of type stubs now, so it should be part of the dependencies.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@freider freider merged commit a8adf32 into main Jan 26, 2024
9 checks passed
@freider freider deleted the freider/typing-extensions-dep branch January 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant