Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return code interpreter example to use exec #961

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

pawalt
Copy link
Member

@pawalt pawalt commented Nov 5, 2024

Previously we had a bug in exec that made it drop some messages. This bug is fixed so we can return to our preferred exec pattern.

Type of Change

  • New example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter (---)
    • Example is tested by executing with modal run or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "deploy"])
    • Example is tested by running with no arguments or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

Previously we had a bug in exec that made it drop some messages. This
bug is fixed so we can return to our preferred exec pattern.
@pawalt
Copy link
Member Author

pawalt commented Nov 5, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @charlesfrye will follow-up review this.

@pawalt
Copy link
Member Author

pawalt commented Nov 5, 2024

@prbot automerge

@modal-pr-review-automation modal-pr-review-automation bot merged commit 015b973 into main Nov 5, 2024
7 checks passed
@modal-pr-review-automation modal-pr-review-automation bot deleted the pawalt/code_interp_fix branch November 5, 2024 16:58
@pawalt
Copy link
Member Author

pawalt commented Nov 5, 2024

whoops i guess automerge doesn't work on this repo

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-b91f452.modal.run

@@ -67,11 +67,11 @@ def driver_program():
# that program and execute code in it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawalt could you also update the text here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants