Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blender_video example to use a .blend file #738

Merged
merged 2 commits into from
May 9, 2024

Conversation

ekzhang
Copy link
Member

@ekzhang ekzhang commented May 9, 2024

I attached a pretty simple .blend file here with a transmissive material to illustrate more of the Cycles renderer, but we insert any .blend file really.

modal-blender-video.mp4

Type of Change

  • Example updates (Bug fixes, new features, etc.)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter (---)
    • Example is tested by executing with modal run or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "deploy"])
    • Example is tested by running with no arguments or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

I attached a pretty simple .blend file here with a transmissive material to illustrate more of the Cycles renderer, but we insert any .blend file really.
@ekzhang ekzhang requested a review from charlesfrye May 9, 2024 19:54
@ekzhang
Copy link
Member Author

ekzhang commented May 9, 2024

This is kind of interesting @charlesfrye but we kind of accidentally rebuilt a GPU render farm

https://blendergrid.com

Copy link
Collaborator

@charlesfrye charlesfrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I get the sense that using the bpy interface the way I was doing it is very uncommon.

And glad to see the new Run CI test fired with a true positive.

@ekzhang ekzhang merged commit 1b26e07 into main May 9, 2024
6 checks passed
@ekzhang ekzhang deleted the ekzhang/blender-video-farm branch May 9, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants