-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run examples on change #735
Conversation
Had to revert the updates to typechecking.
I tried to update So I went back to the old way. Note that we also can't effectively typecheck any code running inside Modal functions, because the dependencies aren't available to |
merging but still welcome C+C/review to improve! |
Was halfway through! haha. Almost got there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for wading through all that YAML 😄
This PR adds a new workflow, Run, that detects changed examples and runs them. This gets us another step closer to full continuous integration of example changes -- it will reduce the number of issues that show up via monitoring (🎉), but we're still missing isolated builds.
To keep testing fast and isolated, all changed examples are executed in parallel job runs (via a jobs
matrix
output by thechanged-files
action).I also centralized the environment setup for the different CI workflows into a single action file, as in the main repo.
FYI, I would not have been able to get this working without the
act
tool, which runs GitHub Actions locally. Really speeds up debugging!Type of Change