Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds rate limit handler from slack SDK #731

Merged
merged 1 commit into from
May 3, 2024

Conversation

charlesfrye
Copy link
Collaborator

the webscraper example is intermittently failing with 429s. the Slack SDK includes a rate limit retry handler, which this PR adds.

ran several scrapes simultaneously without error, so this should suffice, but will monitor.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@charlesfrye charlesfrye merged commit 5923bff into main May 3, 2024
4 checks passed
@charlesfrye charlesfrye deleted the charlesfrye/slack-webscraper-rate-limits branch May 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant