Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for TRELLIS #1022

Merged
merged 1 commit into from
Dec 18, 2024
Merged

add example for TRELLIS #1022

merged 1 commit into from
Dec 18, 2024

Conversation

charlesfrye
Copy link
Collaborator

brings in #1018 by @sandeeppatra96 and @patraxo as a misc example

@charlesfrye
Copy link
Collaborator Author

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-3dc214a.modal.run

@charlesfrye charlesfrye merged commit cc64ef6 into main Dec 18, 2024
7 checks passed
@charlesfrye charlesfrye deleted the charlesfrye/add-trellis3d-misc branch December 18, 2024 15:00
@charlesfrye
Copy link
Collaborator Author

Super cool example!

Screenshot 2024-12-18 at 9 36 39 AM

A few things before we can bring in as a main-line example that'd show up on the docs site:

  • The build process looks pretty messy still (multiple pip install steps that conflict on versions of e.g. Triton, a variety of CUDA versions e.g. 11.8, 12.2, & 12.4). And do we need all of those env vars, e.g. the compiler flags?
  • Pin versions for the pip_installed libraries
  • Put the model into a Volume instead of the Image, make sure no models are downloaded after the first @enter
  • Split out the web serving from the underlying function
  • Write up the example in the "Literate Programming" style

@sandeeppatra96
Copy link

Super cool example!

Screenshot 2024-12-18 at 9 36 39 AM A few things before we can bring in as a main-line example that'd show up on the docs site:
  • The build process looks pretty messy still (multiple pip install steps that conflict on versions of e.g. Triton, a variety of CUDA versions e.g. 11.8, 12.2, & 12.4). And do we need all of those env vars, e.g. the compiler flags?
  • Pin versions for the pip_installed libraries
  • Put the model into a Volume instead of the Image, make sure no models are downloaded after the first @enter
  • Split out the web serving from the underlying function
  • Write up the example in the "Literate Programming" style

I had multiple issues as it was unable to find CUDA_HOME, also even though some libaries were being installed without pin versions they were still not working and even caused issues later on while inferencing. e.g. nvdiffrast and diso library

@charlesfrye
Copy link
Collaborator Author

Word! I've tasked our Devin integration with figuring out the install process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants