Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiders #59

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Spiders #59

wants to merge 21 commits into from

Conversation

Willamin
Copy link
Contributor

@Willamin Willamin commented Nov 6, 2016

This adds

  • spiders
  • mother spiders (which spawn spiders)
  • web spiders (which spawn webs)

https://willamin.github.io/enchiridion/more-spiders/

@Willamin
Copy link
Contributor Author

Willamin commented Nov 6, 2016

I will be adding web spiders before we merge this PR. I just wanted to go ahead and get this out there as a sort of progress update

@ehgoodenough
Copy link
Member

A couple of notes:

  • We should try to use a different image for the regular spiders vs the mother spiders instead of the scaling approach.
  • Spawning a spider from a mother spider should maybe not increase the killcount of the room; it makes it far too difficult.
  • The spiders attack diagonally, so they need a diagonal attack animation. Consult the CSS to see how we're defining the keyframes for attack animations.

Thanks!

@Willamin
Copy link
Contributor Author

Willamin commented Nov 6, 2016

The scaling approach just happened as a result of the spawned spider being on top of the mother spider. On the next move, the spawned spider becomes its normal size. I figured different colors would be sufficient for differentiating between spiders, but we can do a different sprite if you want.

Yeah, it definitely makes the room harder. (I rather enjoyed having to fight off hordes of spiders). Maybe mother spiders shouldn't show up until more difficult rooms or we could just make sure that only 1 mother spider exists at a time.

Excellent point - will do.

@ehgoodenough
Copy link
Member

If nothing else, the mother spider should have a limit of how many spiders she can spawn at a time; for now, limited at 3.

@ehgoodenough
Copy link
Member

Whenever you're ready for a review, could we get an updated build? Thanks! :D

@Willamin
Copy link
Contributor Author

The build isn't consistently working right for me, but here it is:
https://willamin.github.io/enchiridion/spider-build/
alternatively, the compiled files are here https://github.com/Willamin/enchiridion/tree/gh-pages/spider-build

@Willamin
Copy link
Contributor Author

Ready for review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants