WIP: components-first-release #7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Release | ||
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - 'v*' | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| clojars: | ||
| runs-on: ubuntu-latest | ||
| environment: release | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: "DeLaGuardo/[email protected]" | ||
| with: | ||
| cli: "1.11.1.1139" | ||
| - name: release | ||
| env: | ||
| CLOJARS_USERNAME: ${{ secrets.CLOJARS_USERNAME }} | ||
| CLOJARS_PASSWORD: ${{ secrets.CLOJARS_PASSWORD }} | ||
| run: | | ||
| clojure -T:dev:build clean && \ | ||
| clojure -T:dev:build jar && \ | ||
| clojure -T:dev:build install && \ | ||
| clojure -X:deploy-clojars | ||
|
|
||
Felipe-gsilva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| (ns build | ||
| (:require [clojure.tools.build.api :as b])) | ||
|
|
||
| (def lib 'com.github.moclojer/mockingbird) | ||
| (def version "0.0.1") | ||
Felipe-gsilva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| (def class-dir "target/classes") | ||
| (def basis (b/create-basis {:project "deps.edn"})) | ||
| (def jar-file (format "target/%s-%s.jar" (name lib) version)) | ||
|
Comment on lines
+5
to
+9
There was a problem hiding this comment. 💡 Codebase verification Consider Centralizing the Version Number The version number 🔗 Analysis chainLGTM: Project metadata definitions are correct The project metadata definitions look good for a first release. However, for future releases, consider implementing a more flexible version management system. To ensure consistency across the project, let's verify if the version is used elsewhere: To accurately verify if the version number 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for other occurrences of the version number
rg --type-add 'json:*.json' --type-add 'edn:*.edn' --type json,edn,clojure '"0.0.1"'
Length of output: 127 Script: #
#!/bin/bash
# Description: Check for other occurrences of the version number
rg -tjson -tedn -tclojure '"0.0.1"'
Length of output: 470 |
||
|
|
||
| (defn clean [_] | ||
| (b/delete | ||
| {:path "target"})) | ||
|
|
||
| (defn jar [_] | ||
| (b/write-pom | ||
| {:class-dir class-dir | ||
| :lib lib | ||
| :version version | ||
| :basis basis | ||
| :src-dirs ["src"]}) | ||
| (b/copy-dir | ||
| {:src-dirs ["src" "resources"] | ||
| :target-dir class-dir}) | ||
| (b/jar | ||
| {:class-dir class-dir | ||
| :jar-file jar-file})) | ||
|
|
||
| (defn install [_] | ||
| (b/install | ||
| {:basis basis | ||
| :lib lib | ||
| :version version | ||
| :jar-file jar-file | ||
| :class-dir class-dir})) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,66 @@ | ||
| {:deps {:aliases [:dev]} | ||
| :nrepl {:port 9000} | ||
| :builds {:app {:target :browser | ||
| :output-dir "resources/public/assets/js" | ||
| :asset-path "/assets/js" | ||
| :devtools {:reload-strategy :full | ||
| :http-port 8101 | ||
| :http-root "resources/public"} | ||
| :build-hooks [(dev.shadow.hooks/hash-files | ||
| ["./resources/public/assets/css/output.css" | ||
| "./resources/public/assets/js/core.js"]) | ||
| (dev.shadow.hooks/replace-hashed-files | ||
| "./resources/index.src.html" | ||
| "./resources/public/index.html")] | ||
| :dev {:modules {:core {:init-fn dev.core/init}} | ||
| :compiler-options {:warning-as-errors true} | ||
Felipe-gsilva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| :build-hooks [(dev.shadow.hooks/build-css | ||
| true | ||
| "./src/mockingbird/css/tailwind.css" | ||
| "./resources/public/assets/css/output.css")]} | ||
| :release {:modules {:core {:init-fn mockingbird.core/init}} | ||
| :compiler-options {:optimizations :advanced | ||
| :infer-externs :auto | ||
| :source-map true | ||
| :warnings-as-errors true} | ||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion Reconsider Including |
||
| :build-options {:manifest-name "manifest.json"} | ||
| :build-hooks [(dev.shadow.hooks/build-css | ||
| false | ||
| "./src/mockingbird/css/tailwind.css" | ||
| "./resources/public/assets/css/output.css")]}} | ||
| :tests {:target :browser-test | ||
| :test-dir "resources/test" | ||
| :ns-regexp "-test$" | ||
| :devtools {:http-port 8102 | ||
| :http-root "resources/test"}} | ||
|
|
||
| :ci-tests {:target :karma | ||
| :output-to "resources/test/ci.js" | ||
| :ns-regexp "-test$" | ||
| :compiler-options {:static-fns false}} | ||
| :node-lib {:target :node-library | ||
| :output-dir "resources/node/" | ||
| :output-to "resources/node/mockingbird-lib.js" | ||
| :exports-fn mockingbird.node/generate-exports | ||
| :build-hooks [(dev.shadow.hooks/hash-files | ||
| ["./resources/public/assets/css/output.css" | ||
| "./resources/public/assets/js/core.js"]) | ||
| (dev.shadow.hooks/replace-hashed-files | ||
| "./resources/index.src.html" | ||
| "./resources/public/index.html")] | ||
| :dev {:modules {:core {:init-fn dev.core/init}} | ||
| :compiler-options {:warning-as-errors true} | ||
| :build-hooks [(dev.shadow.hooks/build-css | ||
| true | ||
| "./src/mockingbird/css/tailwind.css" | ||
| "./resources/public/assets/css/output.css")]} | ||
| :release {:modules {:core {:init-fn mockingbird.core/init}} | ||
| :compiler-options {:optimizations :advanced | ||
| :infer-externs :auto | ||
| :source-map true | ||
| :warnings-as-errors true} | ||
| :build-options {:manifest-name "manifest.json"} | ||
| :build-hooks [(dev.shadow.hooks/build-css | ||
| false | ||
| "./src/mockingbird/css/tailwind.css" | ||
| "./resources/public/assets/css/output.css")]}}}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
| (:require | ||
| [mockingbird.core :as m])) | ||
|
|
||
| (defn ^:export init | ||
| [] | ||
| (try | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| ;; TODO | ||
|
|
||
| (def styles | ||
| {:mockingbird {}}) | ||
|
There was a problem hiding this comment. 🧹 Nitpick (assertive) LGTM! Consider adding a clarifying comment and addressing the TODO. The change to the
;; Styles map for theme-specific customization
(def styles
{:mockingbird {}})
|
||
|
|
||
| (defnc icon | ||
| [{:keys [class theme label href | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
LGTM! The workflow name and triggers are well-defined.
The workflow name "Release" is clear and descriptive. The triggers are appropriate for a release workflow, allowing for both automated releases on version tags and manual triggering.
Consider adding a brief description comment at the beginning of the file to provide more context:
🧰 Tools
🪛 yamllint