Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inline subscribers not receiving messages when all non-inline clients unsubscribe. #386

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

werbenhu
Copy link
Member

@werbenhu werbenhu commented Apr 12, 2024

This PR fixes the issue #385 where inline subscribers do not receive messages on the same topic after all non-inline clients unsubscribe.

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8708877062

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.771%

Totals Coverage Status
Change from base Build 8708870232: 0.0%
Covered Lines: 6110
Relevant Lines: 6186

💛 - Coveralls

@werbenhu werbenhu changed the title Fix the bug where inline subscribers do not receive messages after all non-inline clients unsubscribe. Fixed inline subscribers not receiving messages when all non-inline clients unsubscribe. Apr 12, 2024
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great find and clean fix. Approving :)

@mochi-co mochi-co merged commit 21491d9 into mochi-mqtt:main Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants