Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update ESLint to 8 #4926

Merged
merged 2 commits into from
Sep 27, 2022
Merged

deps: update ESLint to 8 #4926

merged 2 commits into from
Sep 27, 2022

Conversation

outsideris
Copy link
Contributor

Description of the Change

ESLint 8 was released a year ago.
At that time, we couldn't update it because eslint-config-standard didn't support ESLint.

I fixed for object-shorthand because StandardJS 17 added object-shorthand as warning.

Alternate Designs

Turn off object-shorthand in the eslint configuration.
There is no reason we don't use object-shorthand.

@outsideris outsideris added the type: chore generally involving deps, tooling, configuration, etc. label Sep 24, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.326% when pulling 588d84e on outsideris:eslint-8 into 4e06a6f on mochajs:master.

Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris thank you

@juergba juergba merged commit 51d4746 into mochajs:master Sep 27, 2022
@juergba juergba added this to the next milestone Sep 27, 2022
@juergba juergba added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants