Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of linter rules messages #5470

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

felipecrs
Copy link

I spend some time reviewing the messages of these rules, and I found some little inconsistencies in the style. In my opinion this PR improves them.

@felipecrs
Copy link
Author

felipecrs commented Oct 30, 2024

Some patterns I came up with:

  1. Always refer to keywords using uppercase (e.g. FROM instead of from).
  2. Only quote strings if their content is unknown (i.e. entered by the user) (e.g. a stage name '%s'), or when otherwise the sentence would be confusing ('as' keyword instead of as keyword).
  3. Always use backticks ` to refer to snippets

@tonistiigi tonistiigi requested a review from dvdksn October 31, 2024 03:44
@felipecrs felipecrs marked this pull request as draft October 31, 2024 13:58
@felipecrs felipecrs force-pushed the improve-ruleset-messages branch from 8bf8834 to 277b129 Compare October 31, 2024 13:58
Signed-off-by: Felipe Santos <[email protected]>
@felipecrs felipecrs force-pushed the improve-ruleset-messages branch from 277b129 to 6d26769 Compare October 31, 2024 13:59
@thompson-shaun thompson-shaun added this to the v0.18.0 milestone Oct 31, 2024
@felipecrs felipecrs force-pushed the improve-ruleset-messages branch from 0a33254 to 7438264 Compare October 31, 2024 14:01
@thompson-shaun
Copy link
Collaborator

@felipecrs I think the test cases will also need to be updated. 🙏

@felipecrs
Copy link
Author

For sure @thompson-shaun, I will get around to doing it soon. Please leave this on standby until I update it. Sorry.

@thompson-shaun
Copy link
Collaborator

No worries! Just wanted to call out in case it got lost in the pile. Thank you for the contribution. Reach out if you need assistance.

@thompson-shaun thompson-shaun modified the milestones: v0.18.0, v0.19.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants