-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.11] Backport CVE-2024-23653 #4638
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running interactive container APIs was done by giving the gateway implementation access to worker controller directly, but it should be passed with a build job instead. Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 0971dffaab93d91e51af984b44c745b35b3c5b4d) (cherry picked from commit 0c5daa2)
Ensure interactive calls validate same conditions that the build requests do. Refactor of the build side is to ensure we use the same validation function for both cases. There was no validation issue with the LLB validation. Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit d1970522d7145be5f4a1f1a028b1910bb527126c) (cherry picked from commit 65c3c9c)
dcermak
added a commit
to SUSE/docker
that referenced
this pull request
Mar 6, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface)
This was referenced Mar 20, 2024
https://github.com/moby/buildkit/blob/master/PROJECT.md#feature-releases |
cyphar
pushed a commit
to cyphar/docker
that referenced
this pull request
Jun 24, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface). Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
pushed a commit
to SUSE/docker
that referenced
this pull request
Oct 15, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface). Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
pushed a commit
to SUSE/docker
that referenced
this pull request
Nov 27, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface). Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
pushed a commit
to SUSE/docker
that referenced
this pull request
Dec 11, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface). Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
pushed a commit
to SUSE/docker
that referenced
this pull request
Dec 11, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface). Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
pushed a commit
to SUSE/docker
that referenced
this pull request
Dec 18, 2024
- moby/buildkit#4638 - moby/buildkit#4639 - moby/buildkit#4640 - Backported versions of the various CVE-2024-23650 patches. additionally change the version in builder/builder-next/worker/worker.go and adjust calls to NewGatewayFrontend() in builder/builder-next (Worker is no longer implementing the correct interface). Fixes: CVE-2024-23650 CVE-2024-23651 CVE-2024-23652 CVE-2024-23653 Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #4602 to v0.11