Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graaljs #1949

Closed
wants to merge 3 commits into from
Closed

Update graaljs #1949

wants to merge 3 commits into from

Conversation

tokou
Copy link
Contributor

@tokou tokou commented Aug 25, 2024

Proposed changes

  • Update GraalJs
  • Enable host access and class lookup

Testing

  • Update integration test 102 to add running the sample script

Issues fixed

Fixes #1388

@bartekpacia
Copy link
Member

Hey, thanks a lot @tokou! Unfortunately we're not ready to bump GraalJS just yet, because Maestro targets Java 8, and we don't want to bump it. Our analytics show many our users still use it, despite it being EOL.

@bartekpacia
Copy link
Member

Closing because of reasons given above.

@tokou
Copy link
Contributor Author

tokou commented Aug 30, 2024

@bartekpacia Thanks for the clarification
How can I run a test locally to ensure that the app behaves correctly on Java 8 or not?

@bartekpacia
Copy link
Member

bartekpacia commented Aug 30, 2024

We are setting -Xjdk-release arg for Kotlin compiler (example here) so right now as long as the project builds fine then the Maestro CLI should also work. More on this topic:

So as long as our CI is green, then it will (okay, should - I don't believe anything anymore in this programming world) also work on Java 8.

As for specific commands: try ./gradlew test, if it passes, it will work on Java 8 as well.

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GraalJS engine to latest version
2 participants