add providers oberschwabenmobil, gmuend_bewegt #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
approved these changes
Dec 9, 2024
Comment on lines
+150
to
+151
| if address: | ||
| station['address'] = address |
There was a problem hiding this comment.
Are address / their components really optional? Above, you access them via [], are the properties contained but empty?
There was a problem hiding this comment.
Oberschwaben Mobil has a station "RV-Nordstadt" with geocoordinates, but without any address information. The attributes town, zipcode, street, streetnumber are available, but they are = "".
hbruch
reviewed
Dec 18, 2024
Comment on lines
-61
to
-62
| if provider in ['flinkster']: | ||
| return FlinksterProvider(feed_config) |
There was a problem hiding this comment.
An oversight in the review: you removed the flinkster option here, but kept the import, the config and the FlinksterProvider itself. Either it should be removed completely or kept here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new moqo providers