Nextbike: vehicle_types_available fill-in #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
force-pushed
the
nextbike-vehicle-availability-fixes
branch
from
0b2701d to
cf781c6
Compare
the-infinity
approved these changes
Dec 18, 2023
app/utils/gbfs_util.py
Outdated
| if 'num_bikes_available' in station_status: | ||
| if num_bikes_available != station_status['num_bikes_available']: | ||
| logging.warn( | ||
| f"Official num_bikes_available ({station_status['num_bikes_available']}) does not match count deduced from vehicle_types_available ({num_bikes_available}) at stationn {station_status['station_id']}" |
There was a problem hiding this comment.
Huh? Why does this line work in our linter? It should not? :o
app/utils/gbfs_util.py
Outdated
| station['vehicle_types_available'] = default_vehicle_types_available | ||
|
|
||
|
|
||
| def _count_vehicle_types_at_station(vehicles, filter) -> Counter: |
hbruch
force-pushed
the
nextbike-vehicle-availability-fixes
branch
2 times, most recently
from
731006f to
87d44fc
Compare
hbruch
force-pushed
the
nextbike-vehicle-availability-fixes
branch
from
87d44fc to
f76375e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextbike feeds are currently invalid, as the
station_statusdoes not provide the properyvehicle_types_available.This PR fills them in, as bikes at stations in
free_bike_status.jsonhave their station's id assigned.The
GbfsNextbikeVehicleAvailabilityConvertercounts the number of vehicles per vehicle_type_id at each station and constructs the vehicle_types_available from this information.In cases not a single vehicle is assigned to a station, we add a single vehicle_types_id with count == 0 as vehicle_types_available.
Note that this is a workaround and might be a vehicle_type that will never be available at this station, or a vehicle_type which could be available sometimes will not appear in vehicle_types_available.