Adds score system #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnmaita
approved these changes
Nov 22, 2023
src/game/combat.rs
Outdated
| @@ -146,16 +147,22 @@ fn spawn_projectiles( | |||
|
|
|||
| fn projectile_collision_with_player( | |||
| mut commands: Commands, | |||
| mut player_query: Query<(Entity, &mut ResourcePool<Health>), With<Player>>, | |||
| mut player_query: Query< | |||
| (Entity, &mut ResourcePool<Health>, &mut ScoreSystem<Score>), | |||
There was a problem hiding this comment.
Creo que ya no hace falta que traigas el ScoreSystem aca no? Si es asi aprovecha y borralo asi querias menos cosas.
Comment on lines
+108
to
+109
| score_system.add_with_multiplier(*points); | ||
| score_system.increase_multiplier_by_one(); |
There was a problem hiding this comment.
No se que opinas pero quizas estaria bueno desacoplar la suba del multiplicador de la suma de puntos. Por ej, se me ocurre que solo los edificios te den multiplicador, que son mas dificiles de romper, a que cada enemigo te sume el X. Me suena que si empezamos a spawnear bichos a lo loco con el pasar del tiempo, los numeros se van a ir al re choto. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Closes #35
What was done:
Checklist: