Skip to content

ENH: Help button #9123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2021
Merged

ENH: Help button #9123

merged 3 commits into from
Mar 17, 2021

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR refactors MplCanvas so that canvas not related to Brain can be created. For instance, the help window:

output.mp4

It's an item of #8704

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 17, 2021
agramfort
agramfort approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for MRG if CI are green

video was convincing for me :)

@GuillaumeFavelier GuillaumeFavelier merged commit 5f0beb9 into mne-tools:main Mar 17, 2021
@GuillaumeFavelier GuillaumeFavelier deleted the enh/help_button branch March 17, 2021 14:03
@GuillaumeFavelier
Copy link
Contributor Author

Thanks for review and testing @agramfort

@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 26, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeFavelier @agramfort