-
Notifications
You must be signed in to change notification settings - Fork 1.4k
MRG, MAINT: Better notebook tests #9034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
evts_dct = {'A': 1} | ||
tn, tx = -1, 2 | ||
epochs = Epochs(raw_haemo, evts, event_id=evts_dct, tmin=tn, tmax=tx) | ||
return epochs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here up in this file is git mv
/ old code
@GuillaumeFavelier can you take a look and see if you agree that |
I'm fine not running in the notebook and updating |
Similarly to #9190 (comment), the notebook tests were skipped so I pushed b08647c to fix that. |
The tests are green for me locally and on Azure
Is it still WIP? What is missing? |
Ready for merge except tests still aren't passing on Windows:
I think we probably just need to skip if the platform is Windows because it's probably not supported in some part of the stack. But I think we can rely on it working in practice for people. I'll push a commit to skip there |
Feel free to rebase #9190 and incorporate tests there! |
* MAINT: Encapsulate and separate notebook tests * FIX: Fixture * MAINT: ipytest requirement * ENH: Add * WIP: Closer-ish * FIX * FIX: Scope? * Fix conftest * TST: Skip Windows Co-authored-by: Guillaume Favelier <[email protected]>
nbexec
fixture that can be used to run tests in an IPython kernelReadtest_3d.py
andtest_brain.py
tests intest_notebook.py
and useipytest
to run them (probably), need to figure out how to run only the notebook tests, using the notebook backend. Probably by replacingrenderer_interactive
withrenderer_notebook
using regex or so...