Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Modernize CIs #532

Merged
merged 17 commits into from
Feb 2, 2024
Merged

MAINT: Modernize CIs #532

merged 17 commits into from
Feb 2, 2024

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Feb 2, 2024

  1. Switch to ruff
  2. Switch to unified tests.yml
  3. Get rid of azure
  4. Enable pre-commit
  5. Get rid of tools/* in favor of plain calls

Will get things green, adjust merge reqs, and merge

@@ -179,8 +180,7 @@
# correct.

events, event_dict = mne.events_from_annotations(raw_haemo)
fig = mne.viz.plot_events(events, event_id=event_dict,
sfreq=raw_haemo.info['sfreq'])
fig = mne.viz.plot_events(events, event_id=event_dict, sfreq=raw_haemo.info["sfreq"])

Check warning

Code scanning / CodeQL

Variable defined multiple times

This assignment to 'fig' is unnecessary as it is [redefined](1) before this value is used.
)
if isinstance(state["data"], dict):
for channel in state["data"]:
state["data"][channel] = state["data"][channel].__dict__

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).
if isinstance(
state["data"][channel]["model"], nilearn.glm.regression.OLSModel
):
state["data"][channel]["modelname"] = str(

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).
state["data"][channel]["modelname"] = str(
state["data"][channel]["model"].__class__
)
state["data"][channel]["model"] = state["data"][channel][

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).
"model"
].__dict__
if isinstance(state["data"], nilearn.glm.contrasts.Contrast):
state["data"] = state["data"].__dict__

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@larsoner larsoner enabled auto-merge (squash) February 2, 2024 17:41
@larsoner larsoner merged commit 0d50d80 into mne-tools:main Feb 2, 2024
10 of 11 checks passed
@larsoner larsoner deleted the cis branch February 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant