BUG: Fix largest culprit in speed issue #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pinging @mmagnuski and @linnea-evanson one more time before this gets merged and the issue closed. I'm on a laptop with 32 GB of RAM and 8 cores so I checked the time but I really don't have anything less powerful on hand to test that this really changes the user experience as far as speed. |
|
This is okay to merge by me, will conflict with #27 on one line though (either can go first) |
|
Thanks @alexrockhill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.
@mmagnuski and @linnea-evanson could you check that this is much faster for you?