This repository has been archived by the owner on May 17, 2018. It is now read-only.
Updated to latest version #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e API calls to match the latest version of bitcoind.
|
Nice work. I haven't thoroughly reviewed your changes, but what I saw looked good. That would be great if you could maintain this package from now on. I haven't been able to devote much time to maintenance lately. Do you need any form of official approval for Hackage to let you take over maintainership and upload new versions yourself? If so, let me know and I'll gladly grant the permission. Thanks. |
|
All I need is your blessing. Hackage doesn't have any security on who uploads what, but the community generally behaves itself. Using people's real names helps with that. Would you mind making a commit changing the maintainer on the .cabal to "Clark Gaebel [email protected]"? |
|
Maintainer changed in .cabal in 19f9d35 |
…nal RPC representation.
Conflicts: network-bitcoin.cabal
Small fixes and updates
Add missing fields in HashData
Renamed SinceBlockTransaction to BlockTransaction since it is also used by listTransactions.
Added listAccounts and listTransactions.
Polished listAccounts and listTransactions.
…ork-bitcoin into missingMethods
Missing methods
modify API to reuse HTTP connections via Manager
…ion` thrown by `parseUrl`, fixing #18.
Fix boolean parsing in signrawtransaction response
Rewrite `getClient` to remove `fromJust` and expose `InvalidUrlException...
changePassword called "walletpassphrase" just like unlockWallet, when instead it should call "walletpassphrasechange" according to https://en.bitcoin.it/wiki/Original_Bitcoin_client/API_Calls_list
Fixed changePassword
When calling setGenerate while running bitcoind in regtest mode, setGenerate is supposed to parse a [HexString] rather than Nil in some cases. In regtest mode the setgenerate API call doesn't take a number of processors, but rather a number of hashes to generate, and than proceeds to return these hashes.
Fixed setGenerate in regtest mode
According to [1], sendMany expects a number of minimum confirmations as its third parameter. With null or the comment given as third parameter, as before, bitcoind complained in regtest mode and didn't process the request as expected. [1]: https://bitcoin.org/en/developer-reference#sendmany
Bugfix in sendMany
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated network-bitcoin to match the latest version of bitcoind, as well as the latest depended-on libraries. I look forward to the next release on Hackage.
If you would like, I can continue to maintain this package from now on.