-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.13, update .gitignore, remove duplicate path to prod from workflow #90
Conversation
Reviewer's Guide by SourceryThis PR makes changes to the CI/CD pipeline by modifying the deployment workflow and test configuration. The main changes include removing a redundant production deployment path and adding Python 3.13 support to the test matrix. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mnbf9rca - I've reviewed your changes - here's some feedback:
Overall Comments:
- Instead of commenting out the
deploy_to_pypi_prod_after_test
job, consider removing it entirely. If the code is no longer needed, it's better to rely on version control history rather than keeping commented-out code in the repository.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mnbf9rca - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing Python 3.13 from the test matrix for now as it's still in early development. It would be better to wait until it reaches at least beta status to avoid potential CI instability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Python 3.13 was released Oct. 7, 2024 |
Summary by Sourcery
Add support for Python 3.13 in the test workflow, update the .gitignore file, and remove a duplicate deployment path to production in the CI workflow.
CI:
Chores: