Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13, update .gitignore, remove duplicate path to prod from workflow #90

Merged
merged 8 commits into from
Nov 17, 2024

Conversation

mnbf9rca
Copy link
Owner

@mnbf9rca mnbf9rca commented Nov 17, 2024

Summary by Sourcery

Add support for Python 3.13 in the test workflow, update the .gitignore file, and remove a duplicate deployment path to production in the CI workflow.

CI:

  • Remove duplicate deployment path to production in the deploy workflow.

Chores:

  • Update .gitignore file.

Copy link

sourcery-ai bot commented Nov 17, 2024

Reviewer's Guide by Sourcery

This PR makes changes to the CI/CD pipeline by modifying the deployment workflow and test configuration. The main changes include removing a redundant production deployment path and adding Python 3.13 support to the test matrix.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Streamline deployment workflow by removing redundant production deployment path
  • Remove the 'deploy_to_pypi_prod_after_test' job that was triggered after test deployment
  • Maintain the direct production deployment path through 'deploy_to_pypi_prod_direct'
.github/workflows/deploy_workflow_wrapper.yml
Add Python 3.13 support to test matrix
  • Add Python 3.13 to the list of Python versions in the test matrix
.github/workflows/test_run_pytest.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai bot changed the title @sourcery-ai Comment out redundant PyPI production deployment step Nov 17, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Instead of commenting out the deploy_to_pypi_prod_after_test job, consider removing it entirely. If the code is no longer needed, it's better to rely on version control history rather than keeping commented-out code in the repository.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mnbf9rca mnbf9rca changed the title Comment out redundant PyPI production deployment step Update .gitignore and comment out redundant PyPI production deployment step Nov 17, 2024
@mnbf9rca mnbf9rca changed the title Update .gitignore and comment out redundant PyPI production deployment step Add support for Python 3.13, update .gitignore, remove duplicate path to prod from workflow Nov 17, 2024
@mnbf9rca
Copy link
Owner Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing Python 3.13 from the test matrix for now as it's still in early development. It would be better to wait until it reaches at least beta status to avoid potential CI instability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mnbf9rca
Copy link
Owner Author

  • Consider removing Python 3.13 from the test matrix for now as it's still in early development. It would be better to wait until it reaches at least beta status to avoid potential CI instability.

Python 3.13 was released Oct. 7, 2024

@mnbf9rca mnbf9rca merged commit a34b190 into main Nov 17, 2024
7 checks passed
@mnbf9rca mnbf9rca deleted the chore/add-DS_Store-to-.gitignore branch November 17, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant