-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote attestations from pypi publication #83
Conversation
Reviewer's Guide by SourceryThis pull request modifies the GitHub Actions workflow for building and publishing artifacts to PyPI. The changes primarily focus on improving the deployment process, adding conditional logic for test and production deployments, and adjusting the OIDC (OpenID Connect) configuration. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mnbf9rca - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
||
deploy_to_pypi_prod_direct: | ||
needs: [build_artifacts] | ||
if: ${{ github.event.inputs.deploy_to_test != 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Make the condition for direct production deployment more explicit
The current condition will run whenever deploy_to_test is not 'true', including cases where it's false or not set. Consider using a more specific condition to avoid unintended direct production deployments.
if: ${{ github.event.inputs.deploy_to_test != 'true' }} | |
if: ${{ github.event.inputs.deploy_to_test == 'false' || github.event.inputs.deploy_to_test == '' }} |
Summary by Sourcery
Revise the CI workflow to allow conditional deployment to PyPi production either directly or after a test deployment, based on user input. Remove commented-out code related to OIDC debugging and attestations.
CI: